8000 tr: properly determine trailing backslash by BenWiederhake · Pull Request #6731 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tr: properly determine trailing backslash #6731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

tr: properly determine trailing backslash #6731

merged 1 commit into from
Sep 25, 2024

Conversation

BenWiederhake
Copy link
Collaborator

Buggy behavior before this PR:

$ true | tr '\\\' 'asdf'
tr: warning: an unescaped backslash at end of string is not portable
$ true | cargo run -q --features tr -- tr '\\\' 'asdf'
$

Fixes #6729.

Related to #6713.

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

@BenWiederhake BenWiederhake mentioned this pull request Sep 24, 2024
Open
@cakebaker cakebaker merged commit 457f0ad into uutils:main Sep 25, 2024
67 of 68 checks passed
@cakebaker
Copy link
Contributor

Good catch, thanks!

@BenWiederhake BenWiederhake deleted the dev-tr-trailing-backslash branch September 28, 2024 10:58
@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
@moonfruit moonfruit mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
U - tr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tr: doesn't warn about unescaped trailing backslash
2 participants
@BenWiederhake @cakebaker
0