8000 uucore: Move `pgrep/process.rs` to `uucore` by Krysztal112233 · Pull Request #6483 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

uucore: Move pgrep/process.rs to uucore #6483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jul 10, 2024
Merged

uucore: Move pgrep/process.rs to uucore #6483

merged 27 commits into from
Jul 10, 2024

Conversation

Krysztal112233
Copy link
Contributor

Follow the advance, moved procps/pgrep/process.rs to uucore/process.rs

@Krysztal112233
Copy link
Contributor Author

Waiting for uutils/procps#95 merged

@sylvestre
Copy link
Contributor

Could you please fix the clippy warnings?

@Krysztal112233
Copy link
Contributor Author
Krysztal112233 commented Jun 19, 2024 •
edited
Loading

Could you please fix the clippy warnings?

I'll made a new pr to do this Theres already pr to do this #6482

@cakebaker
Copy link
Contributor

@Krysztal112233 #6482 fixes the clippy errors in shuf.rs but there is also a clippy error shown in your code, see https://github.com/uutils/coreutils/actions/runs/9580690912/job/26415846170?pr=6483

@sylvestre
Copy link
Contributor

please let us know when it is ready

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@Krysztal112233 Krysztal112233 marked this pull request as ready for review July 2, 2024 03:58
@Krysztal112233
Copy link
Contributor Author

The pr related procps has been merged, I think it's time to move the code to uucore :) @sylvestre

@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 2, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@Krysztal112233 Krysztal112233 mentioned this pull request Jul 8, 2024
Merged
sylvestre
sylvestre reviewed Jul 8, 2024
View reviewed changes
@sylvestre
Copy link
Contributor

the coverage isn't ideal:
"62.08% of diff hit (target 87.45%) "
could you please improve it a bit ?
thanks

@Krysztal112233
Copy link
Contributor Author

I need some help XP. @sylvestre @cakebaker

It looks like Codecov is not testing the tests in the process.rs file correctly, what should I do?

@sylvestre
Copy link
Contributor

it isn't a coverage issue but a test:

--- TRY 3 STDERR:        uucore features::process::tests::test_process_information_new ---
thread 'features::process::tests::test_process_information_new' panicked at 'assertion failed: result.is_ok()', src/uucore/src/lib/features/process.rs:576:9
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: core::panicking::panic
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:117:5
   3: uucore::features::process::tests::test_process_information_new
             at ./src/lib/features/process.rs:576:9
   4: uucore::features::process::tests::test_process_information_new::{{closure}}
             at ./src/lib/features/process.rs:574:39
   5: core::ops::function::FnOnce::call_once
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5
   6: core::ops::function::FnOnce::call_once
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

sylvestre
sylvestre reviewed Jul 9, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/rm/rm2. tests/rm/rm2 is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre merged commit 7cf5f5c into uutils:main Jul 10, 2024
63 of 68 checks passed
BenWiederhake added a commit to BenWiederhake/coreutils-rs that referenced this pull request Jul 18, 2024
@BenWiederhake
uucore: add missing import
76af976 
No idea why this is only caught by clippy nightly.
See also uutils#6483
@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
@moonfruit moonfruit mentioned this pull request Nov 22, 2024
Closed
@jtracey jtracey mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Krysztal112233 @sylvestre @cakebaker
0