8000 `printf`: use 0 instead of 0o as octal prefix by tertsdiepraam · Pull Request #5808 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

printf: use 0 instead of 0o as octal prefix #5808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/uucore/src/lib/features/format/num_format.rs
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,17 @@ impl Formatter for UnsignedInt {
let mut s = match self.variant {
UnsignedIntVariant::Decimal => format!("{x}"),
UnsignedIntVariant::Octal(Prefix::No) => format!("{x:o}"),
UnsignedIntVariant::Octal(Prefix::Yes) => format!("{x:#o}"),
UnsignedIntVariant::Octal(Prefix::Yes) => {
// The prefix that rust uses is `0o`, but GNU uses `0`.
// We also need to take into account that 0 should not be 00
// Since this is an unsigned int, we do not need to take the minus
// sign into account.
if x != 0 {
format!("0{x:o}")
} else {
format!("{x:o}")
}
}
UnsignedIntVariant::Hexadecimal(Case::Lowercase, Prefix::No) => {
format!("{x:x}")
}
Expand Down Expand Up @@ -487,6 +497,27 @@ fn strip_fractional_zeroes_and_dot(s: &mut String) {
mod test {
use crate::format::num_format::{Case, ForceDecimal};

#[test]
fn unsigned_octal() {
use super::{Formatter, NumberAlignment, Prefix, UnsignedInt, UnsignedIntVariant};
let f = |x| {
let mut s = Vec::new();
UnsignedInt {
variant: UnsignedIntVariant::Octal(Prefix::Yes),
width: 0,
precision: 0,
alignment: NumberAlignment::Left,
}
.fmt(&mut s, x)
.unwrap();
String::from_utf8(s).unwrap()
};

assert_eq!(f(0), "0");
assert_eq!(f(5), "05");
assert_eq!(f(8), "010");
}

#[test]
fn decimal_float() {
use super::format_float_decimal;
Expand Down
0