8000 cp: make test_closes_file_descriptors Linux-only by cakebaker · Pull Request #5508 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cp: make test_closes_file_descriptors Linux-only #5508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

cp: make test_closes_file_descriptors Linux-only #5508

merged 1 commit into from
Nov 9, 2023

Conversation

cakebaker
Copy link
Contributor

This PR makes test_closes_file_descriptors Linux-only as my solution in #5496 makes the test fail on Android.

@tertsdiepraam
Copy link
Member

Is this something that should fail on android? It not, maybe we could ignore the test on android instead? It's annoying that android is always so tricky!

@cakebaker cakebaker force-pushed the cp_fix_test_closes_file_descriptors branch from 97ec817 to 761213f Compare November 8, 2023 08:33
@cakebaker
Copy link
Contributor Author

I don't know what the behavior on Android should be for this test. So far the test was Linux-only until I enabled it for Android in #5496 to fix the "unused import" warning on Android. With this PR, I simply revert the change from #5496 and fix the "unused import" warning.

@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 8, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail/symlink is no longer failing!

@tertsdiepraam tertsdiepraam merged commit 1cae498 into uutils:main Nov 9, 2023
@cakebaker cakebaker deleted the cp_fix_test_closes_file_descriptors branch November 9, 2023 08:45
@chenrui333 chenrui333 mentioned this pull request Nov 14, 2023
Merged
@moonfruit moonfruit mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @tertsdiepraam
0