8000 yes: support non-UTF-8 args by jeddenlea · Pull Request #4862 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

yes: support non-UTF-8 args #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2023
Merged

yes: support non-UTF-8 args #4862

merged 1 commit into from
May 16, 2023

Conversation

jeddenlea
Copy link
Contributor

Also, tighten the creation of the output buffer. Rather than copy "y\n" 8192 times, or any other input some number of times, it can be doubled in place using Vec::extend_from_within.

@sylvestre
Copy link
Contributor

it has some jobs issues :)

@sylvestre
Copy link
Contributor

I am curious why you are writing this PR ? :)

(it looks good, I am just curious about the use case)

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@jeddenlea
Copy link
Contributor Author

D'oh, I need to get better about checking rustfmt before pushing.

Honestly, I have no personal use case for this. A couple months ago when I first got an itch to try to contribute to this project, I thought I'd start with checking some of the more simple utilities, and yes was the first. I simply noticed it was coercing everything into String while GNU's does not, and thought that should be fixed in case someone else does eventually need to pipe text of some other encoding. 🤷

@jeddenlea
yes: support non-UTF-8 args
3870ee2 
Also, tighten the creation of the output buffer.  Rather than copy "y\n"
8192 times, or any other input some number of times, it can be doubled
in place using Vec::extend_from_within.
@sylvestre sylvestre merged commit f26bf98 into uutils:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeddenlea @sylvestre
0