8000 touch: improve support for dangling link by sylvestre · Pull Request #4769 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

touch: improve support for dangling link #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2023
Merged

touch: improve support for dangling link #4769

merged 5 commits into from
Apr 25, 2023

Conversation

sylvestre
Copy link
Contributor
@sylvestre sylvestre commented Apr 22, 2023 •
edited
Loading

Basically fixing:

ln -s nowhere dangling
touch -h -r dangling file
touch -h dangling
touch -h -

For:
tests/touch/no-dereference.sh

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/touch/no-dereference is no longer failing!
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

cakebaker
cakebaker reviewed Apr 24, 2023
View reviewed changes
cakebaker
cakebaker reviewed Apr 24, 2023
View reviewed changes
cakebaker
cakebaker reviewed Apr 24, 2023
View reviewed changes
cakebaker
cakebaker reviewed Apr 24, 2023
View reviewed changes
cakebaker
cakebaker reviewed Apr 24, 2023
View reviewed changes
cakebaker
cakebaker reviewed Apr 24, 2023
View reviewed changes
cakebaker
cakebaker reviewed Apr 24, 2023
View reviewed changes
sylvestre and others added 5 commits April 24, 2023 12:03
@sylvestre
gnu test: don't sync the po files
afa5c15 
We aren't testing the locale yet.
@sylvestre
touch: -h -r should not fail when running on broken symlink
c3656e5 
Fixes the beginning of:
tests/touch/no-dereference.sh
@sylvestre
touch: -h should not fail when running on broken symlink
aaea758 
Fixes more of tests/touch/no-dereference.sh
@sylvestre
touch: don't generate an error on 'touch -h -'
84e0610
@sylvestre @cakebaker
Improve the doc and simplify the code
c262fa9 
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/touch/no-dereference is no longer failing!

@sylvestre sylvestre requested a review from cakebaker April 24, 2023 11:08
@sylvestre sylvestre merged commit 6115af6 into uutils:main Apr 25, 2023
@sylvestre sylvestre deleted the touch branch April 25, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker approved these changes

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker
0