mv: add progress bar #4220
mv: add progress bar #4220
Conversation
Similarly to `cp`, adds `-g` and `--progress` flags to enable a progress bar via indicatif.
There was a problem hiding this comment.
Excellent! I really like this design. My only important suggestion is that we can simplify the logic around the MultiProgress, by always initializing one if the progress bar flag is passed. Then we can always just add to it instead of having to branch between a MultiProgress and a single ProgressBar.
It's a bit unfortunate that we have to take suspend into account for all the prints, but I don't have a solution for that :)
|
GNU testsuite comparison: |
|
Thank you for all the feedback! |
|
Oh I remembered something right after I merged. @ctsk, could you explain the behaviour also in https://uutils.github.io/user/extensions.html? The source for that is |
Opened a PR here: #4234 |
Similarly to
cp, adds-gand--progressflags to enable a progress bar via indicatif.The logic is tricker than the progress bar logic in
cpand modeled closely to the implementation in advcpmv. In particular, the progress bar does not calculate the total size of the files if the move is performed via a rename operation. To still show adequate feedback, we use two progress bars:Screenshots
Multiple a file and a folder are mv'd across filesystems: