hashsum: enable testing --no-names #4088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Huijeong Kim <herehuijeong@gmail.com>
|
Thanks for having me as a co-author, and thanks for fixing the problem! I tried to run the failed test, but it was not easy for me to just run the test. Could you please let me know how to run gnu test in local? |
|
There are some instructions in the readme. The That being said, I couldn't reproduce this locally, so I'm not sure why it failed in the CI. |
|
Oh! Thanks for sharing that. I tried that.. but have some problem... I'll dig into my problem more and read README description again. Though it is not reproducible in local, I just wanted to know how for later. Thanks a lot! :) |
|
merci :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if we can enable this again.
I'm still not sure why it failed, but it failed on the
unwrapso now I'm only usingunwrap_or. @huijeong-kim I've put you as co-author of this commit :)