8000 `ls -CF` should generate tab and not space · Issue #5396 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ls -CF should generate tab and not space #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sylvestre opened this issue Oct 12, 2023 · 14 comments
Closed

ls -CF should generate tab and not space #5396

sylvestre opened this issue Oct 12, 2023 · 14 comments
Labels
good first issue For newcomers! U - ls

Comments

@sylvestre
Copy link
Contributor

Not far from
#3624

export C="./target/debug/coreutils "
rm -rf e
mkdir -p e/a2345 e/b
printf 'a2345/\tb/\n' > exp

${C}ls -CF e > out
diff -u out exp

tested by GNU:
bash util/run-gnu-test.sh tests/ls/stat-dtype.sh
@sylvestre
Copy link
Contributor Author

#5397 might be a start

@tertsdiepraam
Copy link
Member

This should be added to uutils-term-grid. I'm not a big fan of it myself, but we could support it, as long as formatting with only spaces is still possible.

@sylvestre
Copy link
Contributor Author

I am wondering what is the use case to replace spaces by tabs in the terminal in general...

@tertsdiepraam
Copy link
Member

Slightly less throughput of bytes maybe? I don't really know. The GNU docs just say "efficiency" (https://www.gnu.org/software/coreutils/manual/html_node/General-output-formatting.html).

@5igh5
Copy link
5igh5 commented Oct 18, 2023

Hello. Never contributed to anything before, and this seems like something I could do. How do I start?

@tertsdiepraam
Copy link
Member

Cool! This would first need to be implemented in the uutils-term-grid crate (which is in another repository), so that's where you can start. I would like to confirm with the other maintainers that we actually want this though. I guess that if we want to be fully compatible, we should. @sylvestre @cakebaker what do you think?

@sylvestre
Copy link
Contributor Author

Yeah,we should do it

@tertsdiepraam
Copy link
Member

Alright! @5igh5 so we should first fix up uutils-term-grid so that it has an option for using tabs (with an option to specify how many spaces are replaced by a single tab). Then we can release that and use it in ls.

@allaboutevemirolive allaboutevemirolive mentioned this issue Oct 18, 2023
Closed
@allaboutevemirolive
Copy link
Contributor
< 8000 h3 class="f5 text-normal" style="flex: 1 1 auto">

@tertsdiepraam @sylvestre

Add Tab option #24

@5igh5
Copy link
5igh5 commented Oct 19, 2023

So the issue in uutils-term-grid is solved then?

@sylvestre
Copy link
Contributor Author

@5igh5 sorry but why do you think it is fixed ? :)

@5igh5
Copy link
5igh5 commented Oct 19, 2023

Isn't that the purpose of this PR? uutils/uutils-term-grid#24

@sylvestre
Copy link
Contributor Author

@5igh5 yes but it isn't completed or merged :)

@5igh5
Copy link
5igh5 commented Oct 19, 2023

so... i should go ahead and create my own version of it?

@allaboutevemirolive allaboutevemirolive mentioned this issue Dec 1, 2023
Merged
cakebaker added a commit that referenced this issue Jul 5, 2024
@cakebaker
Merge pull request #6528 from sylvestre/cf
8cc129c 
ls: when -CF is passed, use a tab. closes: #5396
@rm-dr rm-dr mentioned this issue Dec 1, 2024
Closed
This was referenced Mar 27, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For newcomers! U - ls
Projects
GNU Compatibility
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sylvestre @tertsdiepraam @allaboutevemirolive @5igh5
0