8000 dd: error message on count=KBb doesn't match GNU dd, but should · Issue #5905 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

dd: error message on count=KBb doesn't match GNU dd, but should #5905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jfinkels opened this issue Jan 28, 2024 · 1 comment · Fixed by #6622
Closed

dd: error message on count=KBb doesn't match GNU dd, but should #5905

jfinkels opened this issue Jan 28, 2024 · 1 comment · Fixed by #6622
Labels
U - dd

Comments

@jfinkels
Copy link
Collaborator
jfinkels commented Jan 28, 2024 •
edited
Loading

GNU dd:

$ : | dd count=KBb
dd: invalid number: ‘KBb’

uutils dd:

$ : | ./target/debug/dd count=KBb
./target/debug/dd: Unrecognized byte multiplier -> KB

This should be invalid number: 'KBb', just like the GNU version of dd.

This is from the GNU test suite file tests/dd/bytes.sh.
@just-an-engineer
Copy link
Contributor

Working on this in #6622. From looking over the code, it looks like it's based on how we parse it, which results in more differences if anything comes after the first 'c', 'w', or 'b'. As such, dd count=kBb555 also yields different messages on GNU versus here. I'm making that change right now, but I figure I'd add that difference onto this thread

@just-an-engineer just-an-engineer mentioned this issue Sep 4, 2024
Merged
@cakebaker cakebaker linked a pull request Sep 4, 2024 that will close this issue
dd: fix issue #5905 (different error msg from GNU) #6622
Merged
cakebaker pushed a commit that referenced this issue Sep 7, 2024
@just-an-engineer
dd: fix issue #5905 (different error msg from GNU) (#6622)
b89a625 
* Changed dd parsing error message to be in line with GNU dd

* Correct logic to make dd incorrect number error message fully compatible with GNU. Add test

---------

Co-authored-by: just-an-engineer <Julian.Beltz@zetier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
U - dd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dd: fix issue #5905 (different error msg from GNU) just-an-engineer/coreutils
2 participants
@jfinkels @just-an-engineer
0