8000 Switch to a relational database by goto-bus-stop · Pull Request #637 · u-wave/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Switch to a relational database #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 98 commits into from
Nov 22, 2024
Merged

Switch to a relational database #637

merged 98 commits into from
Nov 22, 2024

Conversation

goto-bus-stop
Copy link
Member
@goto-bus-stop goto-bus-stop commented Sep 12, 2024 •
edited
Loading

Closes #549
Remaining items in issue

Mostly works using SQLite. A few things to do:

  • votes
  • vote test uses a non existent history ID, no longer supported
  • playedAt time is wrong (timezones?)
  • i would probably want this to also work with other SQL databases
  • Redis is randomly used for some booth / waitlist / online users related storage. probably just stuff that into a simple key-value table in the database to make it easier to run.
  • use SQL transactions where necessary--with mongodb there are no transactions so a bunch of code YOLO'd consistency, but with a sql database we dont need to yolo anything.
  • put the migration code into a standalone migration script so i can release the next version without depending on mongo
  • performance test it with wlk data. i expect this will be dramatically faster...

This changes how roles work internally (now there's "roles" and "permissions" instead of permissions being specially-treated roles), but it shouldn't be a breaking change for clients.

@goto-bus-stop
It boots from SQL
a1c038b
@goto-bus-stop
progress on loading playlists
1597631
@goto-bus-stop
Use uppercase ID
bd2d299
@goto-bus-stop
Search based on SQL media
1c38da0
@goto-bus-stop
add userID to history entry schema
c4fb407
@goto-bus-stop
stash
68652ad
@goto-bus-stop
Migrate history, read history
3ba9bf8
@goto-bus-stop
Typed IDs; move mostly to new schema types
58a98ac
@goto-bus-stop
Migrate authentication model to SQL
ca864b7
@goto-bus-stop
Update unique constraints
c0fd3f9
@goto-bus-stop
Fix lodash import
cfc72f4
@goto-bus-stop
Select the right stuff from users
20237bf
@goto-bus-stop
Use Object.groupBy
9d8b3a6
@goto-bus-stop
Use order column for playlist sorting?
c45e035 
The other option is to have a JSON column with IDs on the playlists
table.
@goto-bus-stop
Add linting for JSDoc
fed19fe
@goto-bus-stop
SQL config store
6ce9e48
@goto-bus-stop
stash
85e2e26
@goto-bus-stop
Bump kysely
0eb5316
@goto-bus-stop
Different way to store playlist item order
bed0a60
@goto-bus-stop
Opaque -> Tagged
bfd4aed
@goto-bus-stop
Port bans
aaf47c5
@goto-bus-stop
deps: update better-sqlite3
b39eaa9
@goto-bus-stop
Remove mongodb connection code
8b2ae37
@goto-bus-stop
Adding playlist items with sql?
97bfcef
@goto-bus-stop
Revert "Remove mongodb connection code"
7efd42c 
This reverts commit 8b2ae37.
@goto-bus-stop
Make migrations work in sql
c77f66c
@goto-bus-stop
Try with SQLite
27831e1
@goto-bus-stop
Migrate auth passwords
f4d6b6f
@goto-bus-stop
Better Date support for SQLite
81ed9c9
@goto-bus-stop
Use json_each
c900820
@goto-bus-stop goto-bus-stop changed the title Switch to a relational database, closes #549 Switch to a relational database Oct 9, 2024
@goto-bus-stop goto-bus-stop mentioned this pull request Nov 20, 2024
Open
@goto-bus-stop goto-bus-stop marked this pull request as ready for review November 22, 2024 21:46
@goto-bus-stop goto-bus-stop mentioned this pull request Nov 22, 2024
Open
7 tasks
@goto-bus-stop goto-bus-stop merged commit 8765523 into default Nov 22, 2024
11 of 14 checks passed
@goto-bus-stop goto-bus-stop deleted the sql-db branch November 22, 2024 22:10
This was referenced Nov 23, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the database
3 participants
@goto-bus-stop @fawaf @coveralls
0