Rb info #3357
Rb info #3357
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3357 +/- ##
==========================================
+ Coverage 55.86% 59.28% +3.42%
==========================================
Files 615 618 +3
Lines 52480 52689 +209
==========================================
+ Hits 29319 31239 +1920
+ Misses 23161 21450 -1711
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
c77931b to
583d7b3
Compare
| AcpiMcfgSignature = "MCFG" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
The same initialism for this structure.
There was a problem hiding this comment.
I'm actually don't know how to apply initialism rule to Memory-mapped ConFiGuration..., but PCI should be in upper case.
There was a problem hiding this comment.
I am using MCFG now, we need comments from @rminnich @leongross.
Shall we use "PCIMCFGxxx" or "PCIMcfgxxx", in which "MCFG" or "Mcfg" stands for "Memory mapped Configuration".
|
@binjip978 I will address your comments on variables naming later. Thanks for your comments. :) |
4370b34 to
c45b4f2
Compare
|
@binjip978 Thanks for your time and comments. I am testing this PR on more hardware configurations to ensure quality. And will switch from "Draft" to "Ready for review" when all test completed. |
3c7cb66 to
a796c69
Compare
There was a problem hiding this comment.
@AjanZhong you marked the PR ready for review. Does that mean you tested the code on hardware as you announced earlier?
Yes, we have tested this PR on all platforms w/ and w/o graphic in our environment. I think its ready for review now. |
In order to support server with multiple PCI segments, all PCI Root Bridge information should be provided via Device Tree. Segments information are retrieved from ACPI MCFG table, and all Root Bridge information are constructed based on Segments information, along with MMIO and IO resource regions which are fetched from 'resource' file of all PCI devices under same segment. Signed-off-by: Ajan Zhong <ajan.zhong@newfw.com>
Add test case to covering parse ACPI MCFG table and PCI Root Bridge information. Signed-off-by: Ajan Zhong <ajan.zhong@newfw.com>
Add PCI Root Bridge info in Device Tree to support multiple PCI segments.