NAS-136456 / 25.10 / Remove @angular/animations #12181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated all Angular animations to CSS animations following Angular team recommendations: - Migrated 5 components from @angular/animations to CSS transitions/keyframes - Created reusable AnimateOutDirective for animation lifecycle management - Removed provideAnimations() from main.ts reducing bundle size - Added ESLint rule to prevent future @angular/animations usage - Updated tests to handle new animation timing patterns
|
time 2:00 |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #12181 +/- ##
=======================================
Coverage 84.43% 84.44%
=======================================
Files 1747 1748 +1
Lines 61885 61955 +70
Branches 6885 6894 +9
=======================================
+ Hits 52254 52316 +62
- Misses 9631 9639 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RehanY147
requested changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Removes @angular/animations as this package is now deprecated.
Adds one replacement helper directive.
Forbids package use in linter.
Testing:
Test affected places.