8000 NAS-136443 / 25.10 / WebUI should allow adding certificates without including … by undsoft · Pull Request #12178 · truenas/webui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NAS-136443 / 25.10 / WebUI should allow adding certificates without including … #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

undsoft
Copy link
Collaborator
@undsoft undsoft commented Jun 26, 2025

Testing:

See ticket.

@undsoft undsoft requested a review from a team as a code owner June 26, 2025 06:23
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team June 26, 2025 06:23
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-136443: WebUI should allow adding certificates without including … NAS-136443 / 25.10 / WebUI should allow adding certificates without including … Jun 26, 2025
Copy link
codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.43%. Comparing base (86ddffd) to head (adb96b0).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12178   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files        1747     1747           
  Lines       61885    61886    +1     
  Branches     6885     6886    +1     
=======================================
+ Hits        52254    52255    +1     
  Misses       9631     9631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor
@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@undsoft undsoft merged commit a2efbca into master Jun 26, 2025
11 checks passed
@undsoft undsoft deleted the NAS-136443 branch June 26, 2025 08:16
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0