skip flag parsing with zvm run #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `zvm run` can't be used with a zig command that requires flags,
for example `zvm run 0.13.0 build test --summary all` fails because urfave/cli will try to parse the `--summary` flag;
the command fails with this error:
Incorrect Usage: flag provided but not defined: -summary
2025/03/01 22:13:59 ERRO flag provided but not defined: -summary
This commit fixes this by telling urfave/cli to skip flag parsing in
`zvm run`.
|
Hey! This looks good. I just merged it from my phone. Unfortunately, I'm in Portugal this week so I can't publish a full release until I'm back. Thank you for taking the time to add this nice fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
currently
zvm runcan't be used with a zig command that requires flags, for examplezvm run 0.13.0 build test --summary allfails because urfave/cli will try to parse the--summaryflag; the command fails with this error:This PR fixes this by telling urfave/cli to skip flag parsing in
zvm run.