8000 list only sub folders as installed versions (ignoring any other files) by profelis · Pull Request #106 · tristanisham/zvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

list only sub folders as installed versions (ignoring any other files) #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

list only sub folders as installed versions (ignoring any other files) #106

merged 1 commit into from
Dec 3, 2024

Conversation

profelis
Copy link
Contributor
@profelis profelis commented Dec 2, 2024

To ignore .DS_Store files, in my case

@tristanisham
Copy link
Owner

Fair enough! I don't have a Mac to test on, but I'll do my usual tests tomorrow. Should be merged soon enough. Thanks for taking the time to contribute to ZVM!

tristanisham
tristanisham approved these changes Dec 3, 2024
View reviewed changes
Copy link
Owner
@tristanisham tristanisham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Going to switch from key.Type().IsDir() function to the key.isDir() function.

@tristanisham tristanisham merged commit 827b782 into tristanisham:master Dec 3, 2024
1 check passed
@tristanisham
Copy link
Owner

Thanks for taking the time to write a PR for ZVM. I have a particular blind spot for Mac OS since I don't actually own a Mac, so your PR is especially appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanisham tristanisham tristanisham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@profelis @tristanisham
0