feat: add "run" command to invoke a compiler #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit adds a "run" command to zvm that allows you to invoke a zig compiler via its version name. for example: `zvm run 0.14.0 build run --help` which is useful if you switch around projects a lot and just want to run a single command without symlinking the version first.
tristanisham
approved these changes
Nov 14, 2024
|
I had to modify your PR a bit. It didn't cover some edge cases and you used the wrong function to check for symlink validity. Overall though, good PR. Make sure to follow the Go style guide in the future. |
|
Gotcha. It should be calling the binary directly so shouldn't it be just a regular executable and not a symlink? or is there some case where it could be either? It seems like calling |
|
I’d have to go back and check exactly where it was, but it was somewhere
in the validation code. The main issue was that there wasn’t any
validating of what the user passed was a supported version of Zig.
There were also a few cases where you were trying to pass back an error,
but because of how you stacked your error handling the program was
actually sending back a shadowed variable.
Overall, it was a really good PR. I’m glad somebody got the back rolling
on this feature.
|
|
Ah, I see. I'll check it out, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds a "run" command to zvm that allows you to invoke a zig compiler via its version name.
for example:
which is useful if you switch around projects a lot and just want to run a single command without symlinking the version first. I also added the Go install command to the readme.
