8000 Recursively search for ZLS before installing by siniarskimar · Pull Request #88 · tristanisham/zvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Recursively search for ZLS before installing #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

siniarskimar
Copy link
Contributor

Related issue #85

if filepath.Base(path) != filename {
return nil
}
result = path
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't verify if ZLS candidate is executable in a portable way since Windows doesn't mark files as executable

@tristanisham
Copy link
Owner

Great PR. We could always change the filepath.Walk to filepath.WalkDir for better performance. I'm going to test with that switched implementation. There are some little organizational changes I'll make, but your PR is great. Thanks for putting in the time and for contributing to ZVM.

@tristanisham tristanisham 61D3 merged commit a7ae163 into tristanisham:zls-hotfix Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0