Simplifying and making the os tag stringification maintainable #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for this one, I thought |
tristanisham
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
These changes look good! Thank you for taking the time to make optimizations and grammar fixes. There's always room for improvements and you've made some great ones!
After reviewing on my phone, everything looks good. I'll test the switch updates tomorrow along with other bug fixes before we release another alpha.
Have a fantastic Thanksgiving!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains some grammar checks (sorry for not squashing the commit, I wanted to keep those modifications separate), and replaces the exhaustive switch on the OS tag with a compile-time stringification of the enum (the value is replaced by its name, as it seemed intended).
I couldn't read the discord message that was linked in the comment, as it has likely been made unreachable by the conversion of the channel to a forum, I don't know if it needs to be removed.
Thanks for your hard work !