-
Notifications
You must be signed in to change notification settings - Fork 54
ColorSensor: returns color names (index of color name) [WIP] #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SeriousCoder
wants to merge
7
commits into
trikset:master
Choose a base branch
from
SeriousCoder:hsv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elect returned color model; - function read renamed to readRaw; - new function read returns the color index enum (0..7)
…HSV to RGB components vector - rename 'read' to 'getColor';
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=========================================
Coverage ? 33.83%
=========================================
Files ? 162
Lines ? 4014
Branches ? 0
=========================================
Hits ? 1358
Misses ? 2656
Partials ? 0
Continue to review full report at Codecov.
|
e58aa40
to
1c507e2
Compare
8ee914a
to
1a6c3e4
Compare
c636509
to
82504bb
Compare
521d224
to
df70e74
Compare
977fb9a
to
cd7baa8
Compare
d1d317e
to
0a4ad77
Compare
b3c87b7
to
165068c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColorSensor: