Release 1.5.10 #281
Merged
Release 1.5.10 #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes --------- - Extended prompt detection for IOS-like devices to include interstitial space (`\s`) or carriage return (`\r`) characters which is sometimes seen on Arista EOS devices, and would cause asynchronous execution to sometimes hang and result in a `~trigger.exceptions.CommandTimeout` error. - Bugfix in `bin/load_acl` that prevents `queue.complete()` from being called when using the `--no-db` flag. Previously, an `AttributeError` attribute error was raised due to attempting to call `complete` on `queue`, which is set to `None` when passing `--no-db`. - Cleaned up network.utils.ping, removed hostname validation code - Bugfix in `~trigger.utils.network.ping()` where a file descriptor wasn't closed cleanly. - Bugfix in `bin/gnng` that printed device names before any tables, resulting in potentially confusing results. Devices names are now printed with the corresponding table. - Bugfix in `bin/gnng` that allows the `--filter-on-type` to function as expected. - Update documentation of `gnng`'s `-N`/`--nonprod` flag. - Bugfix in `bin/gnng` that allows `gnng` to fail gracefully when a device isn't found. - Bugfix in `bin/gnng --all` that was causing many device vendors to be skipped entirely because the filter was too specific. This vendor filter has been removed and will now fallback to `~trigger.cmds.NetACLInfo()` internal knowledge of supported platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt of reconciling years of squashed merge commits from
developagainstmasterthat I have been doing merely to keep the commit history on themasterbranch OCD clean.I would like to see if the hew new "merge and squash" feature of GitHub can resolve all of this so that we can begin to just so that feature and keep things simpler.