8000 chore: fix some problematic function names by hishope · Pull Request #1163 · trezor/blockbook · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fix some problematic function names #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bchain/basechain.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func (b *BaseChain) EthereumTypeGetErc20ContractBalance(addrDesc, contractDesc A
return nil, errors.New("not supported")
}

// GetContractInfo returns URI of non fungible or multi token defined by token id
// GetTokenURI returns URI of non fungible or multi token defined by token id
func (p *BaseChain) GetTokenURI(contractDesc AddressDescriptor, tokenID *big.Int) (string, error) {
return "", errors.New("not supported")
}
Expand Down
2 changes: 1 addition & 1 deletion bchain/coins/blockchain.go
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ func (c *blockChainWithMetrics) EthereumTypeGetErc20ContractBalance(addrDesc, co
return c.b.EthereumTypeGetErc20ContractBalance(addrDesc, contractDesc)
}

// GetContractInfo returns URI of non fungible or multi token defined by token id
// GetTokenURI returns URI of non fungible or multi token defined by token id
func (c *blockChainWithMetrics) GetTokenURI(contractDesc bchain.AddressDescriptor, tokenID *big.Int) (v string, err error) {
defer func(s time.Time) { c.observeRPCLatency("GetTokenURI", s, err) }(time.Now())
return c.b.GetTokenURI(contractDesc, tokenID)
Expand Down
2 changes: 1 addition & 1 deletion bchain/coins/eth/contract.go
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ func (b *EthereumRPC) EthereumTypeGetErc20ContractBalance(addrDesc, contractDesc
return r, nil
}

// GetContractInfo returns URI of non fungible or multi token defined by token id
// GetTokenURI returns URI of non fungible or multi token defined by token id
func (b *EthereumRPC) GetTokenURI(contractDesc bchain.AddressDescriptor, tokenID *big.Int) (string, error) {
address := hexutil.Encode(contractDesc)
// CryptoKitties do not fully support ERC721 standard, do not have tokenURI method
Expand Down
2 changes: 1 addition & 1 deletion db/rocksdb_ethereumtype.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ type AddrContracts struct {
Contracts []AddrContract
}

// packAddrContract packs AddrContracts into a byte buffer
// packAddrContracts packs AddrContracts into a byte buffer
func packAddrContracts(acs *AddrContracts) []byte {
buf := make([]byte, 0, 128)
varBuf := make([]byte, maxPackedBigintBytes)
Expand Down
0