Add custom group claim #5483
Merged
Add custom group claim #5483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tananaev Please check |
tananaev
reviewed
Dec 19, 2024
Comment on lines
97
to
99
| URI.create(config.getString(Keys.OPENID_ISSUER_URL) + "/.well-known/openid-configuration")) | ||
| .header("Accept", "application/json") | ||
| .build(); |
There was a problem hiding this comment.
Please undo all the formatting changes.
tananaev
reviewed
Dec 19, 2024
| @@ -89,11 +91,12 @@ public OpenIdProvider(Config config, LoginService loginService, HttpClient httpC | |||
| baseUrl = new URI(WebHelper.retrieveWebUrl(config)); | |||
| callbackUrl = new URI(WebHelper.retrieveWebUrl(config) + "/api/session/openid/callback"); | |||
|
|
|||
|
|
|||
|
It doesn't look like you fixed all the places. |
Sorry, i think is is done now |
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OIDC providers don't have "groups" claim in id token, but have "roles". With this setting in traccar.xml there is ability to change it to work properly.
Example is
<entry key='openid.groupsClaimName'>roles</entry>I didn't find how to add new commits to PR so opened new one