Give a solution to #1484 and #1588 #1591
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to give a simplest solution for the unexpected result of reversed in #1484 and #1588.
The functionality of the built-in function reversed should return a reversed iterator of the input.
However, the tqdm does not behave as the common behavior when warped with reversed.
The further detail of the are well-mentioned in the previous issues, #1484 and #1588.
I try to come up with a solution that requires the minimum modification of the original code, and small impact to the performance.
The solution is to use the standard library of Python,
copy
, to shallow copy the original object of the tqdm and replace the self.iterable by the reversed of it.Hope this non-intuitive behavior can be changed.
Thanks.
P.S. Due to the unsigned commit in the previous PR, I open a new one.