std: use SIGWINCH signal to update the size #1538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8e0dc9
to
2920dcb
Compare
987b3a7
to
6b639f7
Compare
SIGWINCH is a signal send to the process when the host terminal is resized, note that it's only available on Unix platforms. Catching this signal allows us to dynamically adapt the number of columns at a very low cost compared to `dynamic_ncols`. Indeed, as this approach is signal based, there is no need to poll the terminal size on each iteration. Signed-off-by: Lucas CHOLLET <lucas.chollet@free.fr>
6b639f7
to
3f15352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIGWINCH is a signal send to the process when the host terminal is
resized, note that it's only available on Unix platforms. Catching this
signal allows us to dynamically adapt the number of columns at a very
low cost compared to
dynamic_ncols. Indeed, as this approach is signalbased, there is no need to poll the terminal size on each iteration.
@casperdcl as you seemed interested here. I didn't use
TMonitoras it seems unrelated to me, people might want to resize their terminals without paying the monitoring cost. But, I'm happy to make the change if you want it.