8000 Some characters aren't displaying properly · Issue #214 · touhouworldcup/thprac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Some characters aren't displaying properly #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
H-J-Granger opened this issue Feb 12, 2025 · 2 comments
Open

Some characters aren't displaying properly #214

H-J-Granger opened this issue Feb 12, 2025 · 2 comments
Assignees
8000 @H-J-Granger
Labels
bug Something isn't working

Comments

@H-J-Granger
Copy link
Collaborator
H-J-Granger commented Feb 12, 2025 •
edited
Loading

Some characters in the glossary list will be shown as a question mark in the in-game UI.

Some known bugs:

  • The English name of a Remilia's spell card: Curse "Curse of Vlad Țepeș", with 'Ț' and 'ș' misdisplayed (see [th06] One spellcard name gets displayed wrong. #195). Note that in English mode, some non-ASCII characters can still be displayed (e.g. Flandre's Taboo "Lævateinn");
  • The Japanese name of Mokou's Undying "Xu Fu's Dimension" (不死「徐福时空」) also has '时' misdisplayed. Note that for this character, '时' is the standard one in the Chinese mainland, not in Japan; in Japan, '時' is the standard way of writing it. These two variants of the same character have different Unicode coding. The same thing happens in the '时' character of her other spell cards, Prescribed "Curse of Tsuki-no-Iwakasa" (时効「月のいはかさの呪い」).

Though these bugs can be easily fixed by replacing the characters, I wonder if there's a way to check all characters to see if there are any left.

Update: The "三" character in Youmu's 天神剣「三魂七魄」also can't be displayed.
@H-J-Granger H-J-Granger changed the title [Bug] Some characters aren't display properly Some characters aren't display properly Feb 12, 2025
@H-J-Granger H-J-Granger added the bug Something isn't working label Feb 12, 2025
@H-J-Granger H-J-Granger self-assigned this Feb 12, 2025
@H-J-Granger H-J-Granger changed the title Some characters aren't display properly Some characters aren't displaying properly Feb 12, 2025
H-J-Granger added a commit that referenced this issue Apr 5, 2025
@H-J-Granger
fix: Fix some inconsistency between spell names and in-game ones (#214)
c174b83
@H-J-Granger
Copy link
Collaborator Author

I checked every Japanese spell card name appeared in thprac_games.def.json (filtered by (?<="[^"]*「[^"]*」[^"]*"[^\n]*")[^"]*「[^"]*」[^"]*) that doesn't appear in this list in commit c174b83. Now the Japanese spell names should be able to display correctly.

@H-J-Granger
Copy link
Collaborator Author
H-J-Granger commented Apr 11, 2025 •
edited
Loading

I also checked every English spell card name (filtered by removing Chinese and Japanese names from the lines containing matches of (?<="[^"]*「[^"]*」[^"]*"[^\n]*")[^"]*「[^"]*」[^"]*). All non-ASCII characters are "æéíóöùúěīŌōūǎǐǒșȚ", where characters "ěīŌōūǎǐǒșȚ" cannot be displayed (all showing a ? in-game).

Here are all the occurrences of these characters:

  • ě: In Evil Sign "Gūhún Yěguǐ" (Yěguǐ, pinyin of 野鬼(イエグイ));
  • ī: In Possession "Corpse Tóngjī" (Tóngjī, pinyin of 童乩(タンキー));
  • Ō: In Otherworld "Ōmagatoki" (Ōmagatoki, Romanization of 逢魔ガ時);
  • ō: In Spirit Link "Tōnglíng Yoshika" (Tōnglíng, pinyin of 通灵(トンリン)), Myōga Ginger "Forget Your Name" (Myōga, Romanization of 茗荷), Myōga Blessing "Behind You" (Myōga, Romanization of 冥加), and Secret Ceremony "Kyōgen of the Back Door" (Kyōgen, Romanization of 狂言);
  • ū, In Revival "Seimei Yūgi -Life Game-" (Yūgi, Romanization of 遊戯) and Evil Sign "Gūhún Yěguǐ" (Gūhún, pinyin of 孤魂(クーフン));
  • ǎ, In Evil Sign "Yǎng Xiǎoguǐ" (Yǎng, pinyin of 养(ヤン) and Xiǎoguǐ, pinyin of 小鬼(シャオグイ));
  • ǐ, In Evil Sign "Yǎng Xiǎoguǐ" (Xiǎoguǐ, pinyin of 小鬼(シャオグイ));
  • ǒ, In Demonify "Zǒuhuǒ Rùmó" (Zǒuhuǒ, pinyin of 走火(ゾウフォ));
  • ș and Ț, in Curse "Curse of Vlad Țepeș" (Țepeș, Romanian family name) ([th06] One spellcard name gets displayed wrong. #195).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@H-J-Granger H-J-Granger

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@H-J-Granger
0