8000 Suggestion: change log level from E_ERROR to E_WARNING · Issue #38 · torden/php-mdbm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Suggestion: change log level from E_ERROR to E_WARNING #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shimashimashi opened this issue Nov 30, 2020 · 3 comments
Closed

Suggestion: change log level from E_ERROR to E_WARNING #38

shimashimashi opened this issue Nov 30, 2020 · 3 comments

Comments

@shimashimashi
Copy link

Current code halts the script on any error because its log level is E_ERROR(not recoverable).

        php_error_docref(NULL TSRMLS_CC, E_ERROR, "failed to open the mdbm");

https://github.com/torden/php-mdbm/blob/master/src/mdbm.c#L1045

Could we use E_WARNING instead?
It is recoverable so users can handle errors.
@torden
Copy link
Owner
torden commented Sep 1, 2022 •
edited
Loading

Hi @shimashimashi

I saw the other modules about opening function.
Your suggestion is Right, I will take this issue and change the E_ERROR to E_WARNING in mdbm_open as soon
Thx for your suggestion.
(Too Late. Quickly Following this issue)

torden added a commit that referenced this issue Sep 1, 2022
@torden
fix #38 change log level from E_ERROR to E_WARNING
32178a6
@torden torden closed this as completed in 9f8c26d Sep 1, 2022
@torden
Copy link
Owner
torden commented Sep 1, 2022

Hi @shimashimashi
Could you plz check up laster version? I did change to E_WARNING
if you have any issue, plz feel free raise issue
Thanks & Best regards.

torden added a commit that referenced this issue Sep 1, 2022
@torden
fix #38 change log level from E_ERROR to E_WARNING
ce35e69
@shimashimashi
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@torden @shimashimashi
0