Stream support for BLAS Handles. #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dominikgrewe I believe this includes all the requested changes on #167 |
|
(Removed THCDeviceTensor* files from pull request) |
|
hey @dominikgrewe all your issues were addressed in this PR. Does this look okay to you? |
| struct TensorMaskedCopyOp { | ||
| TensorMaskedCopyOp(float* s, float* bm) | ||
| : src(s), | ||
| baseMask(bm) { |
|
Sorry for the delay. I was away for a week. I just have a small comment, otherwise it looks good to me. Thanks guys! |
maskedCopy implemented generic Reduce kernels
|
I've removed the unused "baseMask" |
soumith
added a commit
that referenced
this pull request
Jun 24, 2015
Stream support for BLAS Handles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rebased and included Jeff's changes from the previous PR.
maskedCopy implemented
generic Reduce kernels