8000 refactor(examples): add 'type="button"' to button elements by sukvvon · Pull Request #1618 · toss/suspensive · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(examples): add 'type="button"' to button elements #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

refactor(examples): add 'type="button"' to button elements #1618

merged 1 commit into from
Jun 20, 2025

Conversation

sukvvon
Copy link
Contributor
@sukvvon sukvvon commented Jun 20, 2025

Overview

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@sukvvon sukvvon requested a review from manudeli as a code owner June 20, 2025 01:44
@coauthors Coauthors
Copy link
coauthors bot commented Jun 20, 2025 •
edited
Loading

People can be co-author:

Candidate Reasons Count Add this as commit message
@sukvvon #1618 1 Co-authored-by: sukvvon <66409882+sukvvon@users.noreply.github.com>
@codecov-commenter #1618 (comment) 1 Co-authored-by: codecov-commenter <65553080+codecov-commenter@users.noreply.github.com>
@gwansikk #1618 (review) 1 Co-authored-by: gwansikk <39869096+gwansikk@users.noreply.github.com>

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 20, 2025

⚠️ No Changeset found

Latest commit: 337edd7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link
vercel bot commented Jun 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 1:45am

@vercel Vercel
Copy link
vercel bot commented Jun 20, 2025

@sukvvon is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.46%. Comparing base (6449531) to head (337edd7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1618   +/-   ##
=======================================
  Coverage   72.46%   72.46%           
=======================================
  Files          77       77           
  Lines         730      730           
  Branches      151      151           
=======================================
  Hits          529      529           
  Misses        195      195           
  Partials        6        6
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 100.00% <ø> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 84.12% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 100.00% <ø> (ø)
@suspensive/codemods 53.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gwansikk
gwansikk approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator
@gwansikk gwansikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manudeli manudeli merged commit 9127ce8 into toss:main Jun 20, 2025
12 of 13 checks passed
@sukvvon sukvvon deleted the refactor/examples-add-type-to-button branch June 20, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwansikk gwansikk gwansikk approved these changes

@manudeli manudeli Awaiting requested review from manudeli manudeli is a code owner

Assignees
No one assigned
Labels
examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sukvvon @codecov-commenter @gwansikk @manudeli
0