8000 test(react-dom/observe): add fallback tests for 'undefined' 'IntersectionObserver.thresholds' by sukvvon · Pull Request #1580 · toss/suspensive · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test(react-dom/observe): add fallback tests for 'undefined' 'IntersectionObserver.thresholds' #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

test(react-dom/observe): add fallback tests for 'undefined' 'IntersectionObserver.thresholds' #1580

merged 2 commits into from
May 16, 2025

Conversation

sukvvon
Copy link
Contributor
@sukvvon sukvvon commented May 16, 2025 •
edited
Loading

Overview

before

image

after

image

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@sukvvon sukvvon requested a review from manudeli as a code owner May 16, 2025 01:57
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented May 16, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 314ebd0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coauthors Coauthors
Copy link
coauthors bot commented May 16, 2025 •
edited
Loading

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli #1580 (review) #1580 (comment) #1580 (comment) 3 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>
@sukvvon #1580 (comment) #1580 2 Co-authored-by: sukvvon <66409882+sukvvon@users.noreply.github.com>
@codecov-commenter #1580 (comment) 1 Co-authored-by: codecov-commenter <65553080+codecov-commenter@users.noreply.github.com>

@vercel Vercel
Copy link
vercel bot commented May 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 2:57am

@vercel Vercel
Copy link
vercel bot commented May 16, 2025

@sukvvon is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link
codecov-commenter commented May 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.64%. Comparing base (838f78a) to head (314ebd0).
Report is 25 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1580   +/-   ##
=======================================
  Coverage   71.64%   71.64%           
=======================================
  Files          77       77           
  Lines         730      730           
  Branches      151      151           
=======================================
  Hits          523      523           
  Misses        201      201           
  Partials        6        6
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 100.00% <ø> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 84.12% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/codemods 53.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manudeli
Copy link
Member

Resolve conflict please 🙏

@manudeli
Copy link
Member

image

Thanks!!

@sukvvon
Copy link
Contributor Author
sukvvon commented May 16, 2025

@manudeli

Done!

@manudeli manudeli merged commit 10fff93 into toss:main May 16, 2025
12 of 13 checks passed
@sukvvon sukvvon deleted the test/react-dom-observe-threshold-fallback branch May 16, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manudeli manudeli manudeli approved these changes

Assignees
No one assigned
Labels
@suspensive/react-dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sukvvon @codecov-commenter @manudeli
0