8000 fix: resolve issues in JSR publish action by kangju2000 · Pull Request #1479 · toss/suspensive · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: resolve issues in JSR publish action #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2025
Merged

fix: resolve issues in JSR publish action #1479

merged 4 commits into from
Mar 17, 2025

Conversation

kangju2000
Copy link
Collaborator
@kangju2000 kangju2000 commented Mar 17, 2025 •
edited
Loading

Overview

Related with #1475

  • Fixed issues in the JSR publish action.
  • Replaced npx jsr publish with pnpm dlx jsr publish for better compatibility.
  • Added new import paths in jsr.json to properly map package name-style imports to actual paths in JSR, ensuring correct resolution for @suspensive/react-query.
  • Ensured the CI stops if any JSR publish attempt fails by exiting with an error code.

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@kangju2000 kangju2000 self-assigned this Mar 17, 2025
@kangju2000 kangju2000 requested a review from manudeli as a code owner March 17, 2025 16:56
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Mar 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 94a3b1d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coauthors Coauthors
Copy link
coauthors bot commented Mar 17, 2025 •
edited
Loading

People can be co-author:

Candidate Reasons Count Add this as commit message
@kangju2000 #1479 1 Co-authored-by: kangju2000 <23312485+kangju2000@users.noreply.github.com>
@codecov-commenter #1479 (comment) 1 Co-authored-by: codecov-commenter <65553080+codecov-commenter@users.noreply.github.com>
@manudeli #1479 (review) 1 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>

@vercel Vercel
Copy link
vercel bot commented Mar 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 10:19pm
v2.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 10:19pm
v3.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 10:19pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 10:19pm

@kangju2000 kangju2000 requested a review from gwansikk March 17, 2025 16:56
@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 17, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 60.7 kB

ℹ️ View Unchanged
Filename Size
packages/jotai/dist/Atom.cjs 660 B
packages/jotai/dist/Atom.js 115 B
packages/jotai/dist/AtomValue.cjs 647 B
packages/jotai/dist/AtomValue.js 120 B
packages/jotai/dist/index.cjs 753 B
packages/jotai/dist/index.js 158 B
packages/jotai/dist/SetAtom.cjs 645 B
packages/jotai/dist/SetAtom.js 118 B
packages/react-dom/dist/FadeIn.cjs 2.16 kB
packages/react-dom/dist/FadeIn.js 139 B
packages/react-dom/dist/index.cjs 2.38 kB
packages/react-dom/dist/index.js 176 B
packages/react-dom/dist/InView.cjs 2.12 kB
packages/react-dom/dist/InView.js 130 B
packages/react-dom/dist/useFadeIn.cjs 2.07 kB
packages/react-dom/dist/useFadeIn.js 133 B
packages/react-dom/dist/useInView.cjs 1.89 kB
packages/react-dom/dist/useInView.js 120 B
packages/react-native/dist/index.cjs 619 B
packages/react-native/dist/index.js 122 B
packages/react-native/dist/TestText.cjs 612 B
packages/react-native/dist/TestText.js 119 B
packages/react-query-4/dist/index.cjs 1.65 kB
packages/react-query-4/dist/index.js 372 B
packages/react-query-4/dist/infiniteQueryOptions.cjs 548 B
packages/react-query-4/dist/infiniteQueryOptions.js 144 B
packages/react-query-4/dist/Mutation.cjs 821 B
packages/react-query-4/dist/Mutation.js 132 B
packages/react-query-4/dist/PrefetchInfiniteQuery.cjs 722 B
packages/react-query-4/dist/PrefetchInfiniteQuery.js 155 B
packages/react-query-4/dist/PrefetchQuery.cjs 712 B
packages/react-query-4/dist/PrefetchQuery.js 147 B
packages/react-query-4/dist/QueryClientConsumer.cjs 665 B
packages/react-query-4/dist/QueryClientConsumer.js 140 B
packages/react-query-4/dist/queryOptions.cjs 540 B
packages/react-query-4/dist/queryOptions.js 136 B
packages/react-query-4/dist/SuspenseInfiniteQuery.cjs 1.07 kB
packages/react-query-4/dist/SuspenseInfiniteQuery.js 155 B
packages/react-query-4/dist/SuspenseQueries.cjs 928 B
packages/react-query-4/dist/SuspenseQueries.js 149 B
packages/react-query-4/dist/SuspenseQuery.cjs 1.06 kB
packages/react-query-4/dist/SuspenseQuery.js 147 B
packages/react-query-4/dist/usePrefetchInfiniteQuery.cjs 648 B
packages/react-query-4/dist/usePrefetchInfiniteQuery.js 148 B
packages/react-query-4/dist/usePrefetchQuery.cjs 639 B
packages/react-query-4/dist/usePrefetchQuery.js 140 B
packages/react-query-4/dist/useSuspenseInfiniteQuery.cjs 845 B
packages/react-query-4/dist/useSuspenseInfiniteQuery.js 148 B
packages/react-query-4/dist/useSuspenseQueries.cjs 837 B
packages/react-query-4/dist/useSuspenseQueries.js 142 B
packages/react-query-4/dist/useSuspenseQuery.cjs 838 B
packages/react-query-4/dist/useSuspenseQuery.js 140 B
packages/react-query-5/dist/index.cjs 1.36 kB
packages/react-query-5/dist/index.js 370 B
packages/react-query-5/dist/infiniteQueryOptions.cjs 573 B
packages/react-query-5/dist/infiniteQueryOptions.js 144 B
packages/react-query-5/dist/Mutation.cjs 821 B
packages/react-query-5/dist/Mutation.js 132 B
packages/react-query-5/dist/PrefetchInfiniteQuery.cjs 647 B
packages/react-query-5/dist/PrefetchInfiniteQuery.js 145 B
packages/react-query-5/dist/PrefetchQuery.cjs 639 B
packages/react-query-5/dist/PrefetchQuery.js 137 B
packages/react-query-5/dist/QueryClientConsumer.cjs 663 B
packages/react-query-5/dist/QueryClientConsumer.js 140 B
packages/react-query-5/dist/queryOptions.cjs 563 B
packages/react-query-5/dist/queryOptions.js 136 B
packages/react-query-5/dist/SuspenseInfiniteQuery.cjs 833 B
packages/react-query-5/dist/SuspenseInfiniteQuery.js 145 B
packages/react-query-5/dist/SuspenseQueries.cjs 671 B
packages/react-query-5/dist/SuspenseQueries.js 139 B
packages/react-query-5/dist/SuspenseQuery.cjs 825 B
packages/react-query-5/dist/SuspenseQuery.js 136 B
packages/react-query-5/dist/usePrefetchInfiniteQuery.cjs 577 B
packages/react-query-5/dist/usePrefetchInfiniteQuery.js 148 B
packages/react-query-5/dist/usePrefetchQuery.cjs 569 B
packages/react-query-5/dist/usePrefetchQuery.js 140 B
packages/react-query-5/dist/useSuspenseInfiniteQuery.cjs 577 B
packages/react-query-5/dist/useSuspenseInfiniteQuery.js 148 B
packages/react-query-5/dist/useSuspenseQueries.cjs 571 B
packages/react-query-5/dist/useSuspenseQueries.js 142 B
packages/react-query-5/dist/useSuspenseQuery.cjs 569 B
packages/react-query-5/dist/useSuspenseQuery.js 140 B
packages/react-query/dist/index.cjs 552 B
packages/react-query/dist/index.js 121 B
packages/react-query/dist/v4.cjs 550 B
packages/react-query/dist/v4.js 116 B
packages/react-query/dist/v5.cjs 550 B
packages/react-query/dist/v5.js 116 B
packages/react/dist/ClientOnly.cjs 1.07 kB
packages/react/dist/ClientOnly.js 141 B
packages/react/dist/DefaultProps.cjs 1.04 kB
packages/react/dist/DefaultProps.js 167 B
packages/react/dist/Delay.cjs 1.52 kB
packages/react/dist/Delay.js 158 B
packages/react/dist/ErrorBoundary.cjs 2.9 kB
packages/react/dist/ErrorBoundary.js 205 B
packages/react/dist/ErrorBoundaryGroup.cjs 1.64 kB
packages/react/dist/ErrorBoundaryGroup.js 196 B
packages/react/dist/index.cjs 4.04 kB
packages/react/dist/index.js 311 B
packages/react/dist/Suspense.cjs 1.44 kB
packages/react/dist/Suspense.js 171 B

compressed-size-action

@codecov-commenter
Copy link
codecov-commenter commented Mar 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (ceedbae) to head (94a3b1d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1479   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files          69       69           
  Lines         572      572           
  Branches      124      124           
=======================================
  Hits          438      438           
  Misses        129      129           
  Partials        5        5
Components Coverage Δ
@suspensive/react 97.77% <ø> (ø)
@suspensive/react-dom 95.60% <ø> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 83.47% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/codemods 63.47% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

manudeli
manudeli approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member
@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@manudeli manudeli merged commit ae72a0f into next Mar 17, 2025
11 of 15 checks passed
@manudeli manudeli deleted the fix/jsr-publish branch March 17, 2025 22:16
@manudeli manudeli mentioned this pull request Mar 17, 2025
Merged
manudeli added a commit that referenced this pull request Mar 17, 2025
@manudeli
chore: version packages (next) (#1480)
fe5c93a 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @suspensive/react-query@3.0.0-next.8

### Patch Changes

- [#1479](#1479)
[`ae72a0f`](ae72a0f)
Thanks [@kangju2000](https://github.com/kangju2000)! - fix: resolve
issues in JSR publish action

-   Updated dependencies \[]:
    -   @suspensive/react-query-4@3.0.0-next.8
    -   @suspensive/react-query-5@3.0.0-next.8

## @suspensive/codemods@3.0.0-next.8



## @suspensive/jotai@3.0.0-next.8



## @suspensive/react@3.0.0-next.8



## @suspensive/react-dom@3.0.0-next.8



## @suspensive/react-query-4@3.0.0-next.8



## @suspensive/react-query-5@3.0.0-next.8
@manudeli manudeli mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manudeli manudeli manudeli approved these changes

@gwansikk gwansikk Awaiting requested review from gwansikk

Assignees

@kangju2000 kangju2000

Labels
@suspensive/react-query workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kangju2000 @codecov-commenter @manudeli
0