8000 fix: initializing current overlay after close all overlays by ho991217 · Pull Request #119 · toss/overlay-kit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: initializing current overlay after close all overlays #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2025
Merged

fix: initializing current overlay after close all overlays #119

merged 4 commits into from
Feb 15, 2025

Conversation

ho991217
Copy link
Contributor

Description

Related Issue: Fixes N/A

Changes

  • Set current=null after close all overlays.

Motivation and Context

  • useCurrentOverlay could retrieve last current overlay even after overlay.closeAll(); is called.

How Has This Been Tested?

  • Added a unit test to verify if current is unreachable after overlay.closeAll() is called.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

@ho991217 ho991217 requested a review from jungpaeng as a code owner February 15, 2025 19:13
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Feb 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: bdb6b39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
overlay-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link
vercel bot commented Feb 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2025 7:34pm

@codecov-commenter
Copy link
codecov-commenter commented Feb 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (a179aa3) to head (bdb6b39).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   96.71%   96.72%   +0.01%     
==========================================
  Files          12       12              
  Lines         274      275       +1     
  Branches       67       67              
==========================================
+ Hits          265      266       +1     
  Misses          7        7              
  Partials        2        2
Components Coverage Δ
overlay-kit 96.72% <100.00%> (+0.01%) ⬆️

jungpaeng
jungpaeng approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member
@jungpaeng jungpaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jungpaeng jungpaeng merged commit a45f618 into toss:main 740D Feb 15, 2025
10 checks passed
@github-actions github-actions bot mentioned this pull request Feb 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jungpaeng jungpaeng jungpaeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ho991217 @codecov-commenter @jungpaeng
0