Grammer polishing for the README #734
Conversation
|
"MIME type" is correct, "MIME-type" is not, see Media type. Otherwise, this looks good to me! However, there is a tiny amount of overlap with my (still unmerged) clean-up PR #732, so it might make sense to wait until that one is merged and then adjust this one as needed. |
|
Sorry, I should know better. I've reported the incorrect suggestion to app.gammarly.com. I've tried to trigger a notification for the other PR. Hopefully that'll be enough for me to know when to update this. I presume you're OK w/ a rebased commit. |
|
@pradyunsg: do you folks prefer extra commits or a squash-rebase? (I'm assuming I'm waiting on the other PR to merge...) |
|
No preference tbh. Anything works. I'll likely end up squash-merging, so... 🤷♂️ |
|
Alrighty! #732 is merged. Now, this PR has merge conflicts. :) |
|
@pradyunsg: ok, now you can squash merge :-) |
| @@ -157,7 +157,7 @@ first = "Tom" last = "Preston-Werner" # INVALID | |||
| Keys | |||
| ---- | |||
|
|
|||
| A key may be either bare, quoted or dotted. | |||
| A key may be either bare, quoted, or dotted. | |||
There was a problem hiding this comment.
Hmmm... I'm gonna let this slide through. ;)
There was a problem hiding this comment.
I checked before making that change, the document appears to favor Oxford commas. I don't usually go off randomly changing between styles. (My goal is to get things merged, not cause style fights.)
|
Thanks for the PR @jsoref! ^>^ |
No description provided.