8000 Clarify that line-ending backslashes are unescaped by goodmami · Pull Request #729 · toml-lang/toml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clarify that line-ending backslashes are unescaped #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

goodmami
Copy link
Contributor

Part of #728

@eksortso
Copy link
Contributor

LGTM. This will close #728. Thank you!

@ChristianSi
Copy link
Contributor

One little note: Please reflow the paragraph, maximum line length in the README are 80 chars. Looks good otherwise!

@ChristianSi
Copy link
Contributor

Wow, that was fast 😃

@goodmami
Copy link
Contributor Author

:) The diff looks bigger now but it's just the reflowing.

Thanks for the feedback!

Copy link
Member
@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whee! Nice catch!

@pradyunsg pradyunsg merged commit 0050f6f into toml-lang:master Apr 17, 2020
@pradyunsg
Copy link
Member

Thanks for the PR @goodmami ,and for your inputs here @eksortso and @ChristianSi!

@goodmami goodmami deleted the issue-728 branch April 17, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0