8000 Answer:5 by gapablaza · Pull Request #848 · tomalaforge/angular-challenges · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Answer:5 #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Answer:5 #848

wants to merge 1 commit into from

Conversation

gapablaza
Copy link

Checklist for challenge submission

  • Start your PR message with Answer:${challenge_number}

Step 1:

  • Avoid any as a type. Using Interface to leverage Typescript type system prevent errors
  • Use a separate service for all your http calls and use a Signal for your todoList => can be store and service in the same place?
  • Don’t mutate data

Step 2:

  • Add a Delete button: Doc of fake API
  • Handle errors correctly. (Globally)
  • Add a Global loading indicator. You can use MatProgressSpinnerModule

Step 3:

  • Add 2/3 tests => I don't know how to test my code :(

Step 4:

  • Use the component store of ngrx, ngrx/store, rxAngular, tanstack-query or ngrx/signal-store as a local state of your component. => can be only signals?
  • Have a localized Loading/Error indicator, e.g. only on the Todo being processed and disable all buttons of the processed Todo. (Hint: you will need to create an ItemComponent)

Thanks for this challenge!

@github-actions github-actions bot added 5 exercice crud application answer answer labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5 exercice crud application answer answer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gapablaza @tomalaforge
0