You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we have master and develop, as well as a manual trigger. It's not clear to me what the expected workflow is to integrate changes into pypi. Can it be simplified?
This PR is an attempt to simplify the GH actions: yse one .yaml file that does everything.
The motivation behind splitting it in the first place is found here.
What are your thoughts @whitews ? The changes that were made in october 2023 when it was split was probably made for a reason. We should either simplify, or document better.
Sorry I missed this. The CI changes made back then were to allow test suites to run on either the develop or the master branches on pushed commits, while isolating the PyPI builds to the master branch. The PyPI builds were set to be triggered manually as a safe guard for failing master commits. The logic being that new releases are infrequent enough that manual triggers shouldn't pose such a burden versus the risks of publishing broken packages. Apologies if the intention of those changes was unclear, the CI stuff on GitHub can be a maze. Feel free to change as you deem appropriate, I was just trying to be mindful of the increasing number of downstream packages depending on this library.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we have
masteranddevelop, as well as a manual trigger. It's not clear to me what the expected workflow is to integrate changes into pypi. Can it be simplified?.yamlfile that does everything.What are your thoughts @whitews ? The changes that were made in october 2023 when it was split was probably made for a reason. We should either simplify, or document better.