Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a non blocking file appender #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a non blocking file appender #673
Changes from all commits
945f4a8
9ccaa5d
2a34863
39f2709
f251bbe
de77617
7c9ce25
e028dfa
55bdffe
1a70543
5b4eacf
18d0340
c4a8447
1c33af9
6e8cb23
75ee728
e5944c0
cc4fde7
d9968b2
a1f0d01
9316656
ac14ca3
b3aadef
f77a6a8
4417342
64b356f
98db6f7
ec049e0
be7aeb4
e87b631
5d8475c
2983370
8e6a395
80bf8e2
8f9bdc1
e467bdd
4b73a1c
2b6cb51
9e7620d
b415265
4ed792c
93b26af
f494d53
5216e6c
97e5e15
714e5bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably also explain what
WorkerGuard
is , as well as noting that it shouldn't be dropped accidentally :)and, it's fine for users to drop it if they don't care about ensuring that logs are flushed on panics (but they probably do care about this)