Remove (implicit) T: Sized bound from Arc
#226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d65be29 to
6645f98
Compare
Closed
|
Sorry this took so long to review --- this seems like a reasonable approach! @WaffleLapkin are you interested in continuing to work on this? |
|
Yes, I'm still interested! |
This function allows creating `Arc<T>` where `T: !Sized` by unsizing the std's `Arc` first.
6645f98 to
b538d17
Compare
(remove them from the global map on drop of the last `Arc`)
|
@hawkw I believe this is ready for review |
|
(@hawkw friendly ping) |
hawkw
reviewed
Jan 27, 2022
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
|
@hawkw what is left for this PR? |
hawkw
approved these changes
Apr 20, 2022
src/sync/arc.rs
Outdated
| /// use loom::sync::Arc; | ||
| /// | ||
| /// # loom::model::model(|| { | ||
| /// // std's arc can be automatically coerced |
There was a problem hiding this comment.
nit: maybe
Suggested change
| /// // std's arc can be automatically coerced | |
| /// // std's arc can be automatically coerced from a `!Sized` value |
There was a problem hiding this comment.
That's not really correct though, the coercion goes Arc<[u8; 3]> -> Arc<[u8]>, so it is not "from a !Sized value" but more like "to a !Sized value"?
There was a problem hiding this comment.
ah, okay, "to" would also be fine, i just thought it was nice if the comment explicitly stated the coercion that was happening. not a big deal!
src/sync/arc.rs
Outdated
Comment on lines
47
to
54
| /// # loom::model::model(|| { | ||
| /// // std's arc can be automatically coerced | ||
| /// let std = std::sync::Arc::new([1, 2, 3]); | ||
| /// let loom: Arc<[u8]> = Arc::from_std(std); | ||
| /// | ||
| /// let std = std::sync::Arc::new([1, 2, 3]); | ||
| /// let loom: Arc<dyn Sync + Send> = Arc::from_std(std); | ||
| /// # }); |
There was a problem hiding this comment.
a very minor docs suggestion, take it or leave it: it could also be nice to have a compile_fail example showing how loom::sync::Arc::new cannot be used with !Sized values directly, so that users can see why this function is necessary? not a blocker.
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
|
@hawkw I believe I've addressed your nitpicks :) |
hawkw
approved these changes
Apr 23, 2022
|
Yay! 🎉 |
This was referenced Apr 24, 2022
hawkw
added a commit
that referenced
this pull request
May 10, 2022
# 0.5.5 (May 10, 2022) ### Added - sync: Add `Arc::from_std` without `T: Sized` bound (#226) - sync: Implement `Debug` for `AtomicPtr` for all `T` (#255) - logs: Add location tracking for threads and atomic operations (#258) - logs: Add additional location tracking to `Arc`, `alloc`, and `mpsc` (#265) - logs: Improve `tracing` configuration for `LOOM_LOG` (#266) - logs: Add a span for the current model's iteration (#267) ### Documented - Add note about in-memory representation of atomic types (#253) - Document `LOOM_LOG` syntax (#257) ### Fixed - Fix double panic when exceeding the branch limit in `Drop` (#245) - cell: Allow using `{Mut,Const}Ptr::{deref,with}` when the pointee is `!Sized` (#247) - thread: Fix semantics of `thread::park` after `Thread::unpark` (#250)
hawkw
added a commit
that referenced
this pull request
May 13, 2022
# 0.5.5 (May 10, 2022) ### Added - sync: Add `Arc::from_std` without `T: Sized` bound (#226) - sync: Implement `Debug` for `AtomicPtr` for all `T` (#255) - logs: Add location tracking for threads and atomic operations (#258) - logs: Add additional location tracking to `Arc`, `alloc`, and `mpsc` (#265) - logs: Improve `tracing` configuration for `LOOM_LOG` (#266) - logs: Add a span for the current model's iteration (#267) ### Documented - Add note about in-memory representation of atomic types (#253) - Document `LOOM_LOG` syntax (#257) ### Fixed - Fix double panic when exceeding the branch limit in `Drop` (#245) - cell: Allow using `{Mut,Const}Ptr::{deref,with}` when the pointee is `!Sized` (#247) - thread: Fix semantics of `thread::park` after `Thread::unpark` (#250)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to resolve #85