fix(subscriber): use saturating arithmetic for attribute updates #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, an issue exists where a subtraction attribute update for a resource or async op attribute may overflow, if a previous add update was dropped due to event buffer capacity. This may result in the aggregator task panicking. See #180 (comment) for details. This branch changes all resource updates to use saturating arithmetic. In practice, I think it's _much_ more likely for a subtract to overflow due to missed adds than it is for an add to overflow due to missed subs, but I made the addition saturating as well, just in case. We should probably also increase the default event buffer capacity, since it seems like lots of people are hitting problems with this...
hawkw
added a commit
that referenced
this pull request
Dec 20, 2021
It seems like a number of people using the console with real life applications are running into issues related to the console's event buffer being at capacity (e.g. #230, #234, etc). This commit bumps up the default capacity a bit as a quick fix. In the future, I think we should probably do things to avoid reaching the event buffer capacity as often --- I think we can change the aggregator/layer design a bit to avoid creating as many events. But, for now, this should hopefully give people a better default configuration.
hawkw
added a commit
that referenced
this pull request
Dec 21, 2021
It seems like a number of people using the console with real life applications are running into issues related to the console's event buffer being at capacity (e.g. #230, #234, etc). This commit bumps up the default capacity a bit as a quick fix. In the future, I think we should probably do things to avoid reaching the event buffer capacity as often --- I think we can change the aggregator/layer design a bit to avoid creating as many events. But, for now, this should hopefully give people a better default configuration.
hawkw
added a commit
that referenced
this pull request
Jan 18, 2022
<a name="0.1.1"></a> ## 0.1.1 (2022-01-18) #### Bug Fixes * only send *new* tasks/resources/etc over the event channel (#238) ([fdc77e2](fdc77e2)) * increased default event buffer capacity (#235) ([0cf0aee](0cf0aee)) * use saturating arithmetic for attribute updates (#234) ([fe82e17](fe82e17)) #### Changes * moved ID rewriting from `console-subscriber` to the client (#244) ([095b1ef](095b1ef)) ## 0.1.0 (2021-12-16) - Initial release! 🎉
hawkw
added a commit
that referenced
this pull request
Jan 18, 2022
<a name="0.1.1"></a> ## 0.1.1 (2022-01-18) #### Bug Fixes * only send *new* tasks/resources/etc over the event channel (#238) ([fdc77e2](fdc77e2)) * increased default event buffer capacity (#235) ([0cf0aee](0cf0aee)) * use saturating arithmetic for attribute updates (#234) ([fe82e17](fe82e17)) #### Changes * moved ID rewriting from `console-subscriber` to the client (#244) ([095b1ef](095b1ef)) ## 0.1.0 (2021-12-16) - Initial release! 🎉
hawkw
added a commit
that referenced
this pull request
Jan 18, 2022
<a name="0.1.1"></a> ## 0.1.1 (2022-01-18) #### Bug Fixes * only send *new* tasks/resources/etc over the event channel (#238) ([fdc77e2](fdc77e2)) * increased default event buffer capacity (#235) ([0cf0aee](0cf0aee)) * use saturating arithmetic for attribute updates (#234) ([fe82e17](fe82e17)) #### Changes * moved ID rewriting from `console-subscriber` to the client (#244) ([095b1ef](095b1ef))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an issue exists where a subtraction attribute update for a
resource or async op attribute may overflow, if a previous add update
was dropped due to event buffer capacity. This may result in the
aggregator task panicking. See
#180 (comment)
for details.
This branch changes all resource updates to use saturating arithmetic.
In practice, I think it's much more likely for a subtract to overflow
due to missed adds than it is for an add to overflow due to missed subs,
but I made the addition saturating as well, just in case.
We should probably also increase the default event buffer capacity,
since it seems like lots of people are hitting problems with this...