8000 Update broken links in documentation (logging) by dartt0n · Pull Request #1360 · tofu-tf/tofu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update broken links in documentation (logging) #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 12, 2024
Merged

Update broken links in documentation (logging) #1360

merged 4 commits into from
Dec 12, 2024

Conversation

dartt0n
Copy link
Contributor
@dartt0n dartt0n commented Dec 8, 2024

It seems that at some point in the past, the examples branch was deleted, and therefore some links from the documentation became irrelevant. I have updated the links for three examples in logging (simple, service, auto), but there is one broken link left (logback groovy format):

tofu/docs/tofu.logging.recipes.md

Lines 15 to 17 in e563e36

- provide correct logback configuration (except when you are using `tofu.logging` with your own implementation) — you
can find the description [here](./tofu.logging.layouts.md) and the
example [here](https://github.com/tofu-tf/tofu/tree/examples/src/main/resources/logback.groovy).

If you know the new location of this file, please let me know, I will be happy to add the appropriate changes to this pull request.

I have updated the links so that they point to the master branch, or more specifically to the examples/ce2/src/main/scala-2/tofu/example/logging.

@dos65
Copy link
Collaborator
dos65 commented Dec 10, 2024

Thanks for the contribution!

I think the link on logback.groovy should point at examples/ce2/src/main/resources/logback.groovy

@dartt0n
Copy link
Contributor Author
dartt0n commented Dec 10, 2024

Thanks for the contribution!

I think the link on logback.groovy should point at examples/ce2/src/main/resources/logback.groovy

Thanks for the hint! I have pushed another commit with corresponding changes

@dos65 dos65 merged commit 708dc46 into tofu-tf:master Dec 12, 2024
9 checks passed
@dos65
Copy link
Collaborator
dos65 commented Dec 12, 2024

Thx!. Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dos65 dos65 dos65 approved these changes

@Odomontois Odomontois Awaiting requested review from Odomontois Odomontois is a code owner

@danslapman danslapman Awaiting requested review from danslapman danslapman is a code owner

@catostrophe catostrophe Awaiting requested review from catostrophe catostrophe is a code owner

@FunFunFine FunFunFine Awaiting requested review from FunFunFine FunFunFine is a code owner

@oskin1 oskin1 Awaiting requested review from oskin1 oskin1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dartt0n @dos65
0