Fixes and py311 #43
Merged
Fixes and py311 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to introduce compatibility with Python 3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the notebook, so it should work again. Assigned
eomto object in order to access it through the notebook.Uses dict-access for the result.
I also faced problems with using Python 3.11. Turns out default values for custom classes needs to be created through
dataclasses.fieldand its default_factory. So I changed this, thusfrispyshould also be able to support Python 3.11 now.As matplotlib is a hard dependency and not needed for the package to work I moved it to the
dev-dependencies.Also, I fix the warning for the deprecation of
np.float. As suggested it uses nowfloatinstead. With this change tests now also run with Python >3.10.Should be able to close #42