a11y: allow switching back-and-forth from the style panel #6286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
MitjaBezensek
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
Nice 👍
Noticed one thing:
- when I press ⌘ + Enter the first time I don't get the focus ring on the first color
- if I then press escape and then ⌘ + Enter again I do get the focus ring
It's like that in production as well, so not related to this PR, but just wanted to share it.
CleanShot.2025-06-19.at.15.23.35.mp4
|
Adding end to end tests! I noticed / fixed one issue which is that pressing Cmd+Enter to complete editing rich text (in geo shapes) would not re-focus the canvas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Cmd+Enter shortcut, you can then adjust styles in the style panel.
However, the issue is that it's very tricky to get back to the shape you were manipulating. Hitting Escape takes you back to an unfocused canvas at the moment.
This change makes it so that you can hit Escape and focus the container again properly.
Change type
bugfiximprovementfeatureapiotherRelease notes