8000 refactor: remove type casting to improve safety by nayounsang · Pull Request #6101 · tldraw/tldraw · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove type casting to improve safety #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove type casting to improve safety #6101

wants to merge 1 commit into from

Conversation

nayounsang
Copy link
Contributor
@nayounsang nayounsang commented May 20, 2025 •
edited
Loading

Describe what your pull request does. If you can, add GIFs or images showing the before and after of your change.

Change type

  • bugfix
  • improvement
  • feature
  • api
  • other

Test plan

run test & everything is fine
(this is the result for Editor)

Test Suites: 28 passed, 28 total
Tests:       197 passed, 197 total
Snapshots:   32 passed, 32 total
Time:        9.302 s
Ran all test suites.

Release notes

  • Remove unnecessary type casting in Editor/getShapeAtPoint

@vercel Vercel
Copy link
vercel bot commented May 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
analytics ❌ Failed (Inspect) May 20, 2025 3:16pm

@huppy-bot huppy-bot bot added the improvement Product improvement label May 20, 2025
@vercel Vercel
Copy link
vercel bot commented May 20, 2025

@nayounsang is attempting to deploy a commit to the tldraw Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link
vercel bot commented May 20, 2025

Deployment failed with the following error:

The `vercel.json` schema validation failed with the following message: `rewrites[2]` should NOT have additional property `headers`

Learn More: https://vercel.com/docs/concepts/projects/project-configuration

steveruizok
steveruizok reviewed May 20, 2025
View reviewed changes
Copy link
Collaborator
@steveruizok steveruizok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is... not our best code. Is the logic here just that "the shape has a label and the label has text and the pointer is in the label?

Not sure why note shape is included here as it would still be selected even if the point is not in the label.

steveruizok
steveruizok reviewed May 20, 2025
View reviewed changes
Copy link
Collaborator
@steveruizok steveruizok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dupe

@nayounsang
Copy link
Contributor Author

@steveruizok It's definitely weird. I think I need to revisit the logic itself. Does dupe mean that you've already worked on that area?

@nayounsang
Copy link
Contributor Author
nayounsang commented May 23, 2025 •
edited
Loading

The tldraw team can do it, and I am willing to improve this logic. I can get to work quickly (within 2-3 days).
plz tell me the direction.

63F2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveruizok steveruizok steveruizok left review comments

Assignees
No one assigned
Labels
improvement Product improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nayounsang @steveruizok
0