Convert hard coded tag prefixes into calls to authenticators and validators #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aforge
approved these changes
Jul 11, 2020
| defaultMaxLoginLength = 32 | ||
|
|
||
| defaultMinPasswordLength = 3 | ||
| ) | ||
|
|
||
| // Token suitable as a login: starts with a Unicode letter (class L) and contains Unicode letters (L), | ||
| // numbers (N) and underscore. | ||
| var loginPattern = regexp.MustCompile(`^\pL[_\pL\pN]+$`) |
There was a problem hiding this comment.
Do we actually want to allow using non-Latin characters in logins?
There was a problem hiding this comment.
I have that book site and although the instruction says "login should be made of latin characters and numbers" about 25% of users choose Cyrillic logins. I just don't see why we should limit it. There is no technical reason to limit. It's not obvious to me that there is a product reason.
server/auth/rest/README.md
Outdated
| @@ -321,7 +321,9 @@ If accounts are managed by the server, the server should respond with an error ` | |||
|
|
|||
| ### `rtagns` Get a list of restricted tag namespaces. | |||
|
|
|||
| Server may enforce certain tag namespaces to be restricted, i.e. not editable by the user. | |||
| Server may enforce certain tag namespaces (tag prefixes) to be restricted, i.e. not editable by the user. | |||
| These are also used when searching for users. | |||
There was a problem hiding this comment.
Maybe rephrase:
These are also used in Tinode discovery mechanism (e.g. searching for users, contact sync) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewriteTagmethod was refactored to call validators and authenticators to get tags instead of using hardcoded prefixestel,emailandbasic. It required some refactoring in other places.