-
Notifications
You must be signed in to change notification settings - Fork 0
Feat: Add Command (STDIO) Mode and Refactor Core Logic (Fixes #8) #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timthesinner
merged 19 commits into
main
from
<
10000
a title="timthesinner/smart-mcp-proxy:feature/command-stdio-mode" class="no-underline " href="/timthesinner/smart-mcp-proxy/tree/feature/command-stdio-mode">feature/command-stdio-mode
Apr 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… launch config updates
- Added ProxyServer.CallTool method for core tool execution. - Updated command mode to use CallTool and correct JSON-RPC formats. - Updated HTTP mode to use CallTool for POST /tool/:toolName endpoint. - Adjusted tests for command and HTTP modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements GitHub issue #8, adding support for running the smart-mcp-proxy in a command (STDIO) mode using JSON-RPC 2.0, in addition to the existing HTTP mode.
Key changes:
--mode
flag andMCP_PROXY_MODE
env var to select mode.cmd/proxy/command_mode.go
adhering to JSON-RPC 2.0 spec.ProxyServer
methods incmd/proxy/proxy.go
.cmd/proxy/http_mode.go
) to use the refactored core logic.CallToolResult
) between modes.docker/Dockerfile
to default to command mode, allowing override.cmd/proxy/main_test.go
) for parity with command mode tests.README.md
,docs/usage.md
,docs/configuration.md
).Fixes #8