Add profile selection dialog #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds ride-profile–specific filtering and selection to reminders, updates manifest generation to use a configurable base URL, and bumps the Karoo extension dependency.
- Introduce
enabledRideProfilestoReminderand helperreminderIsActive - Add UI for selecting ride profiles in
DetailScreenand filter cards inMainScreen - Extend the Karoo extension pipeline to stream and apply active ride profile, plus CI/build updates
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Bumped io.hammerhead:karoo-ext to version 1.1.5 |
| app/src/main/kotlin/de/timklge/karooreminder/screens/Reminder.kt | Added enabledRideProfiles and reminderIsActive helper |
| app/src/main/kotlin/de/timklge/karooreminder/screens/MainScreen.kt | Filter reminder cards by the active ride profile |
| app/src/main/kotlin/de/timklge/karooreminder/screens/DetailScreen.kt | Added ride-profile selection dialog and state plumbing |
| app/src/main/kotlin/de/timklge/karooreminder/KarooReminderExtension.kt | Wire active profile into trigger jobs and filter logic |
| app/src/main/kotlin/de/timklge/karooreminder/Extensions.kt | New streamActiveRideProfile extension method |
| app/src/main/AndroidManifest.xml | Switched manifest URL to $BASE_URL$ placeholder |
| app/build.gradle.kts | Generate manifest.json (and patch AndroidManifest) from BASE_URL env |
| .github/workflows/android.yml | CI: env var defaults, Android SDK setup, release action tweaks |
Comments suppressed due to low confidence (2)
app/src/main/kotlin/de/timklge/karooreminder/KarooReminderExtension.kt:238
- [nitpick] This
streamDataFlowname shadowskarooSystem.streamDataFlow(...)and can be confusing. Consider renaming it to something likecombinedStreamData.
val streamDataFlow = combine(streamPreferences(), karooSystem.streamActiveRideProfile()) { reminders, activeProfile ->
app/src/main/kotlin/de/timklge/karooreminder/screens/Reminder.kt:150
- This new filtering logic would benefit from unit tests covering profiles-enabled, profiles-empty, and null current profile scenarios to prevent regressions.
fun reminderIsActive(reminder: Reminder, currentRideProfile: RideProfile?): Boolean {
app/src/main/kotlin/de/timklge/karooreminder/screens/Reminder.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/de/timklge/karooreminder/screens/MainScreen.kt
8000
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #53