[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the way schema ids are generated #19

Closed
wants to merge 5 commits into from
Closed

Change the way schema ids are generated #19

wants to merge 5 commits into from

Conversation

etaque
Copy link
@etaque etaque commented Apr 4, 2018

This PR fixes two blocker for us:

  • Allow the use of lists at a top level by adding type args in ids.
  • Hide canonical names in ids to avoid exposing app internals.

We also bumped a few deps on top of #17

andrew-domino and others added 5 commits March 5, 2018 12:01
@andrew-domino
Update libraries and sbt to latest
8cd0591 
This brings docless up to:
  - cats 1.x
  - circe 0.9
  - sbt 1.1.x

Fixes timeoutdigital#16
@andrew-domino
Update travisci builds
c9fe78c
@andrew-domino
Only depend on 2.11.x that all libs support
d041984
@etaque
Use type args in JsonSchema ids to avoid id collision for lists
f8928c6 
Without this, lists as JsonSchema instances do share the same id, `scala.collection.immutable.List`
This also further upgrade dependencies.
@etaque
Use short version of type names to avoid exposing internals.
24c359d
@etaque etaque closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etaque @andrew-domino