8000 Destroy FullCalendar properly by laander · Pull Request #186 · timekit-io/booking-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Destroy FullCalendar properly #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2018
Merged

Destroy FullCalendar properly #186

merged 1 commit into from
Aug 31, 2018

Conversation

laander
Copy link
Contributor
@laander laander commented Aug 30, 2018 •
edited
Loading

Motivation

When the widget is destroyed, make sure to also destroy the fullCalendar instance properly (which removes event listeners).

This might fix some async bugs with FC stuff being called after the widget is already "destroyed".

Tests

Made a simple test.

Who should review it

@Trolzie

@vistik
Copy link
vistik commented Aug 31, 2018

🎱

@laander laander merged commit 3341b2a into master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laander @vistik
0