8000 fix: French translations by BoboTiG · Pull Request #114 · thuliteio/doks-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: French translations #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our < 8000 a class="Link--inTextBlock" href="https://docs.github.com/terms" target="_blank">terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: French translations #114

merged 2 commits into from
Nov 21, 2024

Conversation

BoboTiG
Copy link
Contributor
@BoboTiG BoboTiG commented Nov 19, 2024

Summary

Brief explanation of the proposed changes.

Basic example

Include a basic example, screenshots, or links.

Motivation

Why are we doing this? What use cases does it support? What is the expected outcome?

Checks

  • Read Creating a pull request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test (if relevant)

Copy link
changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: 31f6e0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thulite/doks-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -48,7 +48,7 @@ other = "Chargement de l'index de recherche…"
other = "Pas de recherche récente"

[search_no_results]
other = "Pas de résultats"
other = "Aucun résultat"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fix, but a better wording IMO.

Copy link 8000
Member
@h-enk h-enk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Te-k, LGTM but I'm not a native French speaker — what's your take on this?

@Te-k
Copy link
Contributor
Te-k commented Nov 21, 2024

Yes, that sounds better, thanks @BoboTiG !

@h-enk h-enk merged commit 7351820 into thuliteio:main Nov 21, 2024
@BoboTiG BoboTiG deleted the patch-1 branch November 21, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0