8000 Update terms.html by simplemindedbot · Pull Request #109 · thuliteio/doks-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update terms.html #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to o 8000 ur terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Update terms.html #109

merged 2 commits into from
Oct 7, 2024

Conversation

simplemindedbot
Copy link
Contributor
@simplemindedbot simplemindedbot commented Oct 4, 2024

Summary

For taxonomy terms, we should use .Page.Title or simply .Title instead of .Params.title. This will correctly display the name of each term (category, tag, etc.) in the list.

Also used the len function in Hugo to count the number of pages in each term.

Basic example

You can see the updated behavior here: https://sr4001.net/tags/ or https://sr4001.net/categories/

Screenshot:
taxonomyterms

Motivation

The current implementation does not show the taxonomy terms, only a right arrow (→) in the href for the term. The

Checks

  • Read Creating a pull request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test (if relevant)

For taxonomy terms, we should use .Page.Title or simply .Title instead of .Params.title. This will correctly display the name of each term (category, tag, etc.) in the list.

Also used the len function in Hugo to count the number of pages in each term.
Copy link
changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: b9fae7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thulite/doks-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member
@h-enk h-enk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@h-enk h-enk merged commit ef2f134 into thuliteio:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0